@alison-mk Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

1 package in this PR

• custom-functions-runtime on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have passed
• ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 47749,
  "author": "alison-mk",
  "owners": [
    "OfficeDev",
    "akrantz",
    "mscharlock",
    "davidchesnut",
    "alison-mk"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "0c2efe4",
  "headCommitOid": "0c2efe4d0d6672b5ff8d77299df9cfa6ee2d9ee2",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-18T01:05:15.000Z",
  "reopenedDate": "2020-09-18T16:33:19.000Z",
  "lastCommentDate": "2020-09-18T02:33:31.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47749/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "custom-functions-runtime"
  ],
  "files": [
    {
      "path": "types/custom-functions-runtime/index.d.ts",
      "kind": "definition",
      "package": "custom-functions-runtime"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0c2efe4d0d6672b5ff8d77299df9cfa6ee2d9ee2/checks?check_suite_id=1209766048",
  "lastReviewDate": "2020-09-18T18:02:15.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

🔔 @OfficeDev @akrantz @mscharlock @davidchesnut — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@alison-mk The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ElizabethSamuel-MSFT Any idea what's wrong?

@alison-mk The CI failure fell in the window between releasing @definitelytyped/definitions-parser v0.0.54, which includes microsoft/DefinitelyTyped-tools#93, and landing #44091, which I've just marked ready for review.

The DefinitelyTyped-tools change enables it to find files that previously required exceptions, and #44091 removes those exceptions. The changes are interdependent: Regardless of which lands first, there's a window of CI failure. Apologies!

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

I just published @types/custom-functions-runtime@1.3.0 to npm.